Add quarkus.hibernate-orm.database.version-check.enabled #43762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/documentation
area/hibernate-orm
|
/cc @gsmet (hibernate-orm) |
|
Marking for backport, as this workaround is needed to make Quarkus 3.15 work with CockroachDB in particular. |
yrodiere
force-pushed
the
i43703-workaround
branch
from
79d8b0c
to
426f839
Compare
This comment has been minimized.
This comment has been minimized.
yrodiere
force-pushed
the
i43703-workaround
branch
from
426f839
to
65fc626
Compare
This comment has been minimized.
This comment has been minimized.
This allows disabling the check on startup if one knows the database won't be reachable. It also currently defaults to being disabled when a dialect is set explicitly (`quarkus.hibernate-orm.dialect=something`), in order to work around problems we have with correctly detecting the version on some databases that we don't have tests for (unsupported ones).
yrodiere
force-pushed
the
i43703-workaround
branch
from
65fc626
to
6daa2ea
Compare
yrodiere
added
the
triage/waiting-for-ci
Status for workflow
|
|
🙈 The PR is closed and the preview is expired. |
gsmet
approved these changes
Oct 8, 2024
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows disabling the check on startup if one knows the database won't be reachable.
It also currently defaults to being disabled when a dialect is set explicitly (
quarkus.hibernate-orm.dialect=something), in order to work around problems we have with correctly detecting the version on some databases that we don't have tests for (unsupported ones).This is a workaround for #43703 and #42255, but is not a fix: we will need Hibernate ORM 7.0 for an actual fix that makes database version checks work correctly even on Azure SQL Server or CockroachDB.