Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: fix generated ValueResolver for default methods with params #43653

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Qute: fix generated ValueResolver for default methods with params #43653

merged 1 commit into from
Oct 2, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 2, 2024

@mkouba mkouba requested a review from ia3andy October 2, 2024 13:14
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Oct 2, 2024
@mkouba mkouba mentioned this pull request Oct 2, 2024
Open
ia3andy
ia3andy approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 2, 2024
@mkouba mkouba merged commit b208ba2 into quarkusio:main Oct 2, 2024
22 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 2, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 2, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 2, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fdd1ae4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/qute The template engine
Projects
None yet
Milestone
3.15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @ia3andy @gsmet