Oracle JDBC update preview to stable

[melloware]

Discussed on Zulip

[maxandersen]

the preview is for the native image part as it relies on oracle proprietary driver.

[gsmet]

Yeah, we discussed it with @yrodiere and we think it's not really more preview than other things. And both Oracle and us are committed to somehow make it work so we were leaning towards dropping the preview status, thus why @melloware created the PR.

[melloware]

@maxandersen i brought this up because of this..

This is making my customer nervous who is considering switching from Spring Boot to Quarkus they don't understand why its still Preview?

[yrodiere]

the preview is for the native image part as it relies on oracle proprietary driver.

If you're somehow worried about the future of native for the Oracle driver, I'd understand -- I know there's been conversations, happening behind-the-scene because of the proprietary nature of the driver, so you probably have more information than I do.

However, it's not sustainable to mark the whole extension as preview for such a popular DB.

IMO at the very least we should drop the preview status, and add a warning to the documentation about the preview status of native support only for this driver.

Ideally we'd just drop the preview status entirely, but as I said, I'm not working with all the information here.

[tsegismont]

@melloware sorry I'm late to the party. The Vert.x Oracle Client API is now considered stable so the corresponding extension can be updated as well (both the Reactive Oracle and JDBC Oracle extenstions depend on the Oracle JDBC driver)

[melloware]

OK let me update that one too!

[melloware]

Done @tsegismont !

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 88aa4c5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[yrodiere]

the preview is for the native image part as it relies on oracle proprietary driver.

If you're somehow worried about the future of native for the Oracle driver, I'd understand -- I know there's been conversations, happening behind-the-scene because of the proprietary nature of the driver, so you probably have more information than I do.

However, it's not sustainable to mark the whole extension as preview for such a popular DB.

IMO at the very least we should drop the preview status, and add a warning to the documentation about the preview status of native support only for this driver.

Ideally we'd just drop the preview status entirely, but as I said, I'm not working with all the information here.

@maxandersen , bump ^. Should I consider you're opposed to merging? Would a warning in the documentation, as mentioned above, change your mind?

[maxandersen]

@tqvarnst wdyt?

If we mark all these driver equally supported but Oracle is not going to release fixes in community neither we nor spring boot can claim this to be supported beyond "best effort".

I have no issue having full support in Jvm mode - that's always been fully supported.

[tqvarnst]

Removing the preview does not mean that it's supported. It indicates that we consider the extension and driver stable, which I believe we can do, considering that we haven't had many issues around this. So, I'm +1 to removing the preview and marking it as stable. To be clear, this differs from supporting it in an enterprise distribution of Quarkus.

[yrodiere]

@tqvarnst wdyt?

If we mark all these driver equally supported but Oracle is not going to release fixes in community neither we nor spring boot can claim this to be supported beyond "best effort".

I have no issue having full support in Jvm mode - that's always been fully supported.

Removing the preview does not mean that it's supported. It indicates that we consider the extension and driver stable, which I believe we can do, considering that we haven't had many issues around this. So, I'm +1 to removing the preview and marking it as stable. To be clear, this differs from supporting it in an enterprise distribution of Quarkus.

@maxandersen , agreed? Or do you want a disclaimer in the documentation about native mode with Oracle being "best effort"?

[maxandersen]

+1 on merging as it makes users think javavm is not fully supported where it is.

lets merge and separate from findinb ways to better capture where there are limits on native image compared to jvm.