Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce per invocation override of REST Client's base URL #43331

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 17, 2024

This is done by introducing the @Url annotation that can be placed on a method parameter.
When this parameter is not null, it will be used as the base URL for the specific invocation.

This is done by introducing the @url annotation
that can be placed on a method parameter.
When this parameter is not null, it will be
used as the base URL for the specific invocation

Closes: quarkusio#43316
Copy link

github-actions bot commented Sep 17, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Sep 17, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 3c4e614.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/documentation area/rest labels Sep 17, 2024
Copy link

quarkus-bot bot commented Sep 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3c4e614.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@geoand geoand merged commit 9c8ee9f into quarkusio:main Sep 17, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 17, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 17, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 17, 2024
@geoand geoand deleted the #43316 branch September 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to set the base URL of the REST Client when actually performing the call
2 participants