Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: improve TemplateNode/ResultNode processing #43006

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 4, 2024

This PR is a cherry-pick of 7b4504a and 5ac15a9.

CC @franz1981

@mkouba mkouba requested a review from gastaldi September 4, 2024 09:43
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Sep 4, 2024
@mkouba mkouba mentioned this pull request Sep 4, 2024
@mkouba
Copy link
Contributor Author

mkouba commented Sep 4, 2024

RESULTS SUMMARY          |3.8.6                    |3.14.1                   |999-SNAPSHOT             
=========================|Score    |Error  |Diff   |Score    |Error  |Diff   |Score    |Error  |Diff   
-------------------------|-------------------------|-------------------------|-------------------------
HelloParser              |      666|     35|       |      668|     35|     0%|      674|     33|    +1%
HelloSimple              |    25636|    910|       |    25334|    638|    -1%|    27683|    976|    +9%
IfComplex                |     5974|    235|       |     5950|    184|     0%|     5990|    288|    +1%
IfSimple                 |     7998|    312|       |     7933|    398|    -1%|     8076|    422|    +2%
IncludeSimple            |    21075|    866|       |    21746|    664|    +3%|    23142|   1054|    +6%
JavaBeanValueResolver    |    31383|   1920|       |    31773|   1329|    +1%|    35550|   1303|   +12%
LetComplex               |     6170|    351|       |     5970|    284|    -3%|     6561|    193|   +10%
LetSimple                |    16793|    641|       |    16737|    436|     0%|    18176|   1067|    +9%
Loop15                   |    33668|   1676|       |    33138|   1616|    -2%|    39650|   1841|   +20%
Loop50                   |    10606|    472|       |    10540|    362|    -1%|    11801|    820|   +12%
NameResolver             |    18763|    631|       |    18610|    410|    -1%|    20033|    539|    +8%
When                     |     9137|    434|       |     8873|    459|    -3%|     8831|    504|     0%

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 4, 2024
@franz1981
Copy link
Contributor

@mkouba that's getting interesting :)
IDK why i didn't get a huge speedup overall with my changes all in .-.

Copy link

quarkus-bot bot commented Sep 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 09be8e6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit 3a705d4 into quarkusio:main Sep 4, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 4, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants