Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the compatibility layer for the Big Reactive Rename #43005

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 4, 2024

The change has been done in 3.9 and the deprecation will be in 3.15 LTS so we can now consider removing all this.

While our tendency would be to keep them forever, they come with a cost both in terms of size of BOM (which reflects in the build memory usage for all Quarkus projects), and in terms of config cost - we will reduce the number of interceptors quite a lot.

We did the change in 3.9 and the deprecations will be in 3.15 LTS so we
can get rid of them.
@gsmet gsmet marked this pull request as draft September 4, 2024 09:09
@gsmet
Copy link
Member Author

gsmet commented Sep 4, 2024

Let's start with a draft as I might have left some tests around so let's catch them :).

@geoand
Copy link
Contributor

geoand commented Sep 4, 2024

+100 for this

Copy link

github-actions bot commented Sep 4, 2024

🎊 PR Preview bd33359 has been successfully built and deployed to https://quarkus-pr-main-43005-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@geoand
Copy link
Contributor

geoand commented Sep 4, 2024

The TCK failure of JAXRSClient0012 is weird...

gsmet added a commit to gsmet/resteasy-reactive-testsuite that referenced this pull request Sep 5, 2024
We did the change in 3.9 and the deprecations will be in 3.15 LTS so we
can get rid of them.
@gsmet gsmet marked this pull request as ready for review September 5, 2024 08:40
@gsmet
Copy link
Member Author

gsmet commented Sep 5, 2024

@geoand I was having a look this morning. It was due to: gsmet/resteasy-reactive-testsuite@762d369 .

I chased all the test failures, it's now ready to go!

Copy link

quarkus-bot bot commented Sep 5, 2024


🌘 This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fd78192.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

Awesome, thanks!

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously didn't review this, but I trust you and CI fully :)

Copy link

quarkus-bot bot commented Sep 5, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fd78192.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants