Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maven 4] Replace ${maven.multiModuleProjectDirectory} with ${session.rootDirectory} #42440

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 9, 2024

This will be when we migrate to Maven 4.
While Maven 3.9.2 also introduces ${session.rootDirectory}, it is not usable in POM files, only in the Maven config itself.

/cc @aloubyansky for your awareness.

Fixes #42430

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/documentation labels Aug 9, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot

This comment has been minimized.

@manofthepeace
Copy link
Contributor

This should be removed as well; .mvn/maven.config (for mvn 4)

@gsmet
Copy link
Member Author

gsmet commented Aug 9, 2024

Ah yes, it makes perfect sense, let me adjust.

…tory}

This will be when we migrate to Maven 4.
While Maven 3.9.2 also introduces ${session.rootDirectory}, it is not
usable in POM files, only in the Maven config itself.
@gsmet gsmet force-pushed the drop-maven.multiModuleProjectDirectory branch from cdcb0e6 to de2205e Compare August 9, 2024 12:01
@gsmet
Copy link
Member Author

gsmet commented Aug 9, 2024

done!

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit de2205e.

Failing Jobs

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Failures Logs Raw logs Build scan
Documentation Build Build ⚠️ Check → Logs Raw logs 🚧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

[Maven 4] Get rid of ${maven.multiModuleProjectDirectory}
2 participants