Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] 3.8.6 backports 3 #42362

Merged
merged 18 commits into from
Aug 8, 2024
Merged

[3.8] 3.8.6 backports 3 #42362

merged 18 commits into from
Aug 8, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 7, 2024

Please don't merge, I will merge it myself.

geoand and others added 16 commits August 7, 2024 14:08
(cherry picked from commit 70727f1)
It uses Mutiny, which requires CP to be initialised

(cherry picked from commit ad06f24)
(cherry picked from commit 6625d56)
Bumps [org.jboss.logmanager:jboss-logmanager](https://github.com/jboss-logging/jboss-logmanager) from 3.0.4.Final to 3.0.6.Final.
- [Release notes](https://github.com/jboss-logging/jboss-logmanager/releases)
- [Commits](jboss-logging/jboss-logmanager@3.0.4.Final...3.0.6.Final)

---
updated-dependencies:
- dependency-name: org.jboss.logmanager:jboss-logmanager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 8e3ea49)
- fix regression introduced in
quarkusio#33984
- if there are multiple type-safe templates with the same parameter
declaration then _no_ or _incomplete_ value resolver may be generated

(cherry picked from commit ba3f62a)
…ram(..)

Previously `?` in query parameter values where encoded as is which caused
invalid URL values. We now replace `?` characters in query parameter values with
`%3F`.

Fixes quarkusio#41060

Signed-off-by: Thomas Darimont <[email protected]>
(cherry picked from commit f244de0)
(cherry picked from commit 5d0a210)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Aug 7, 2024
@gsmet gsmet self-assigned this Aug 7, 2024
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/context-propagation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/gradle Gradle area/hibernate-orm Hibernate ORM area/jackson Issues related to Jackson (JSON library) area/oidc area/persistence OBSOLETE, DO NOT USE labels Aug 7, 2024
@quarkus-bot quarkus-bot bot added area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/resteasy-classic area/rest area/smallrye area/spring Issues relating to the Spring integration area/vertx labels Aug 7, 2024
@quarkus-bot quarkus-bot bot changed the title 3.8.6 backports 3 [3.8] 3.8.6 backports 3 Aug 7, 2024
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

brunobat and others added 2 commits August 8, 2024 09:26
(cherry picked from commit 81d23b8)
Doesn't work very well on Windows CI as deleting files can be
problematic.
See:
quarkusio#40537 (comment)

(cherry picked from commit 0c7b77f)
@quarkus-bot quarkus-bot bot added area/jbang Issues related to when using jbang.dev with Quarkus area/maven labels Aug 8, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 8, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1f3b87d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1f3b87d.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
JVM Tests - JDK 21 Build Failures Logs Raw logs 🚧
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/mailer/runtime 
! Skipped: extensions/mailer/deployment integration-tests/mailer integration-tests/virtual-threads/mailer-virtual-threads 

📦 extensions/mailer/runtime

io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectButDeprecatedTrustStore line 38 - History - More details - Source on GitHub

java.util.concurrent.CompletionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)
	at io.smallrye.mutiny.groups.UniAwait.indefinitely(UniAwait.java:46)
	at io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectButDeprecatedTrustStore(MailerTruststoreTest.java:38)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectTrustStore line 25 - History - More details - Source on GitHub

java.util.concurrent.CompletionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)
	at io.smallrye.mutiny.groups.UniAwait.indefinitely(UniAwait.java:46)
	at io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectTrustStore(MailerTruststoreTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/mailer/runtime 
! Skipped: extensions/mailer/deployment integration-tests/mailer integration-tests/virtual-threads/mailer-virtual-threads 

📦 extensions/mailer/runtime

io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectButDeprecatedTrustStore line 38 - History - More details - Source on GitHub

java.util.concurrent.CompletionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)
	at io.smallrye.mutiny.groups.UniAwait.indefinitely(UniAwait.java:46)
	at io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectButDeprecatedTrustStore(MailerTruststoreTest.java:38)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectTrustStore line 25 - History - More details - Source on GitHub

java.util.concurrent.CompletionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)
	at io.smallrye.mutiny.groups.UniAwait.indefinitely(UniAwait.java:46)
	at io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectTrustStore(MailerTruststoreTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/mailer/runtime 
! Skipped: extensions/mailer/deployment integration-tests/mailer integration-tests/virtual-threads/mailer-virtual-threads 

📦 extensions/mailer/runtime

io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectButDeprecatedTrustStore line 38 - History - More details - Source on GitHub

java.util.concurrent.CompletionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)
	at io.smallrye.mutiny.groups.UniAwait.indefinitely(UniAwait.java:46)
	at io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectButDeprecatedTrustStore(MailerTruststoreTest.java:38)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectTrustStore line 25 - History - More details - Source on GitHub

java.util.concurrent.CompletionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)
	at io.smallrye.mutiny.groups.UniAwait.indefinitely(UniAwait.java:46)
	at io.quarkus.mailer.runtime.MailerTruststoreTest.sendMailWithCorrectTrustStore(MailerTruststoreTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet
Copy link
Member Author

gsmet commented Aug 8, 2024

The mailer tests are failing because of a certificate issue AFAICS. We probably need to backport some test infra there.

Probably not a simple backport though from what I can see.

@gsmet gsmet merged commit a6eb921 into quarkusio:3.8 Aug 8, 2024
50 of 53 checks passed
Copy link

github-actions bot commented Aug 8, 2024

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/context-propagation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/gradle Gradle area/hibernate-orm Hibernate ORM area/infra internal and infrastructure related issues area/jackson Issues related to Jackson (JSON library) area/jbang Issues related to when using jbang.dev with Quarkus area/maven area/oidc area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/rest area/resteasy-classic area/smallrye area/spring Issues relating to the Spring integration area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.