Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support APT processors in Gradle quarkusdev #42317

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Aug 5, 2024

  • Support passing the APT processor paths to our dev mode so that it runs APT processors during hot reload

  • Support passing the proper gradle output path for APT so annotation-generated source files end up in the proper place

  • Fixes Better support for APT in dev mode: Gradle part #38228

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Aug 5, 2024
@FroMage
Copy link
Member Author

FroMage commented Aug 5, 2024

I have tested that this works for Hibernate jpamodelgen, and I also have tested that before this patch, it did not run APT processors.

What I don't understand @aloubyansky is that the Gradle IT tests already test that we support hot reload in dev mode for lombok and that lombok is run again during hot reload, in CompileOnlyDependencyDevModeTest.

I don't understand why this test passes, given that we never passed the proper APT flags to our dev mode builder, or how it's different to Hibernate's jpamodelgen, which did not work before this patch.

Do you have any idea?

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Aug 6, 2024

The test failures seem related

@FroMage
Copy link
Member Author

FroMage commented Aug 6, 2024

Definitely

@FroMage
Copy link
Member Author

FroMage commented Aug 21, 2024

That's a multi-language build with scala+java, so we get two generated APT source folders, let's try to disentangle that.

@FroMage
Copy link
Member Author

FroMage commented Aug 21, 2024

@aloubyansky could I get a little Gradle help please? #42317 (comment)

@aloubyansky
Copy link
Member

@FroMage afaics, CompileOnlyDependencyDevModeTest is disabled

@FroMage
Copy link
Member Author

FroMage commented Aug 21, 2024

@FroMage afaics, CompileOnlyDependencyDevModeTest is disabled

Oh, that would explain things :)

@FroMage
Copy link
Member Author

FroMage commented Aug 21, 2024

Alright, so it passes when I enable it, I'll tweak it to test jpamodelgen to make sure that one also works, but it's a good step :)

This comment has been minimized.

@FroMage
Copy link
Member Author

FroMage commented Aug 22, 2024

Alright, now with a test, showing lombok and jpamodelgen work. Ready for review @aloubyansky :)

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on becoming one of the maintainers of the Quarkus Gradle plugin @FroMage ! and thank you :)

Copy link

quarkus-bot bot commented Aug 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cd82d5c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@FroMage
Copy link
Member Author

FroMage commented Aug 22, 2024

Congratulations on becoming one of the maintainers of the Quarkus Gradle plugin @FroMage ! and thank you :)

Oh hell nooooo!!! 😂😂😂😂

@FroMage FroMage merged commit 59d8bf7 into quarkusio:main Aug 22, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 22, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 22, 2024
@FroMage FroMage deleted the 38228 branch August 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for APT in dev mode: Gradle part
3 participants