-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support APT processors in Gradle quarkusdev #42317
Conversation
I have tested that this works for Hibernate jpamodelgen, and I also have tested that before this patch, it did not run APT processors. What I don't understand @aloubyansky is that the Gradle IT tests already test that we support hot reload in dev mode for lombok and that lombok is run again during hot reload, in I don't understand why this test passes, given that we never passed the proper APT flags to our dev mode builder, or how it's different to Hibernate's jpamodelgen, which did not work before this patch. Do you have any idea? |
This comment has been minimized.
This comment has been minimized.
The test failures seem related |
Definitely |
That's a multi-language build with scala+java, so we get two generated APT source folders, let's try to disentangle that. |
@aloubyansky could I get a little Gradle help please? #42317 (comment) |
@FroMage afaics, |
Oh, that would explain things :) |
Alright, so it passes when I enable it, I'll tweak it to test jpamodelgen to make sure that one also works, but it's a good step :) |
This comment has been minimized.
This comment has been minimized.
Alright, now with a test, showing lombok and jpamodelgen work. Ready for review @aloubyansky :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on becoming one of the maintainers of the Quarkus Gradle plugin @FroMage ! and thank you :)
Status for workflow
|
Oh hell nooooo!!! 😂😂😂😂 |
Support passing the APT processor paths to our dev mode so that it runs APT processors during hot reload
Support passing the proper gradle output path for APT so annotation-generated source files end up in the proper place
Fixes Better support for APT in dev mode: Gradle part #38228