Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap CompletionException when dealing with CompletionStage in REST server #42003

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 19, 2024

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 36a44e9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 independent-projects/resteasy-reactive/server/vertx

org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldNotTryToSendToClosedSink - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

@geoand geoand merged commit 8a5ffdb into quarkusio:main Jul 19, 2024
46 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 19, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 19, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.0 Jul 22, 2024
@geoand geoand deleted the #41996 branch August 1, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus rest error handling for WebApplicationExceptions and CompletionStage does not work anymore
3 participants