Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove erroneous check in AbstractJpaOperations#getSession #42002

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Remove erroneous check in AbstractJpaOperations#getSession #42002

merged 1 commit into from
Jul 19, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 19, 2024 •
edited
Loading

@geoand geoand requested a review from yrodiere July 19, 2024 13:29
yrodiere
yrodiere approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2024
@geoand
Copy link
Contributor Author

geoand commented Jul 19, 2024

🙏🏼

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2dd89e1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 65b9c8d into quarkusio:main Jul 19, 2024
27 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 19, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 19, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.0 Jul 22, 2024
@geoand geoand deleted the #42001 branch August 1, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/panache kind/bugfix
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

Panache for Hibernate ORM assumes the datasource has the same name as the persistence unit
3 participants
@geoand @yrodiere @gsmet