Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assertions in templated normal test to more realistic ones #41958

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

holly-cummins
Copy link
Contributor

This is a tiny little change, just pulling some standalone content out of #34681. One of the tests I added a while ago (which is still disabled until #27821 is fixed) checks that even if you don't have a @QuarkusTest annotation in your test, you still see instrumented bytecode in your test class. I don't think that's a realistic expectation, so adjusting the test to give it a better change of passing when it is enabled.

Copy link

quarkus-bot bot commented Jul 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f8aa2e9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 1f69d1d into quarkusio:main Jul 18, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants