Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: removed collections, which are updated, but never queried #41735

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Improvement: removed collections, which are updated, but never queried #41735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ls/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,13 +671,11 @@ private void addLocalProject(ResolvedDependency project, GradleDevModeLauncher.B
final ArtifactSources testSources = project.getWorkspaceModule().getTestSources();
if (testSources != null) {
Set<Path> testSourcePaths = new LinkedHashSet<>();
Set<Path> testSourceParentPaths = new LinkedHashSet<>();

final Set<Path> testClassesDirs = new HashSet<>(testSources.getSourceDirs().size());
for (SourceDir src : testSources.getSourceDirs()) {
if (Files.exists(src.getDir())) {
testSourcePaths.add(src.getDir());
testSourceParentPaths.add(src.getDir().getParent());
if (src.getOutputDir() != null) {
testClassesDirs.add(src.getOutputDir());
}
Expand Down
2 changes: 0 additions & 2 deletions extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,6 @@ && isNotLocatedByCustomTemplateLocator(locatorPatternsBuildItem.getLocationPatte

Map<String, String> bindings = new HashMap<>();
List<Type> parameters = canonicalConstructor.parameterTypes();
List<String> parameterNames = new ArrayList<>(parameters.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

for (int i = 0; i < parameters.size(); i++) {
Type type = parameters.get(i);
String name = canonicalConstructor.parameterName(i);
Expand All @@ -500,7 +499,6 @@ && isNotLocatedByCustomTemplateLocator(locatorPatternsBuildItem.getLocationPatte
+ "] conflicts with an interface method of " + recordInterface);
}
bindings.put(name, getCheckedTemplateParameterTypeName(type));
parameterNames.add(name);
}
AnnotationValue requireTypeSafeExpressions = checkedTemplateAnnotation != null
? checkedTemplateAnnotation.value(CHECKED_TEMPLATE_REQUIRE_TYPE_SAFE)
Expand Down
Loading