Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: add limit of messages kept for a Dev UI connection #41439

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 25, 2024

  • otherwise the connection can consume all memory and the UI may become unresponsive, e.g. if an endpoint sends a new message every millisecond

- otherwise the connection can consume all memory and the UI may become
unresponsive, e.g. if an endpoint sends a new message every millisecond
Copy link

quarkus-bot bot commented Jun 25, 2024

/cc @cescoffier (devui), @phillip-kruger (devui)

Copy link

quarkus-bot bot commented Jun 25, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2536d52.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit bcf4a59 into quarkusio:main Jun 26, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 26, 2024
@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

@mkouba should we backport to 3.12 or it's a new development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants