Set quarkus.application.name and quarkus.application.version in the default source for the Gradle plugin
#41337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he default source for the Gradle plugin
gsmet
reviewed
Jun 24, 2024
Comment on lines
+78
to
+79
| Set<File> resourcesDirs = getSourceSet(project, SourceSet.MAIN_SOURCE_SET_NAME).getResources().getSourceDirectories() | ||
| .getFiles(); |
Member
There was a problem hiding this comment.
I'm not sure MAIN_SOURCE_SET_NAME always exists? Or did we check that before?
Member
Author
There was a problem hiding this comment.
This was inlined from https://github.com/quarkusio/quarkus/pull/41337/files#diff-2c6f0d62b0763af665a1bc242ad078ce25794f20632651181549d838e3452998L118. I can revert that back and put it into two methods.
gsmet
approved these changes
Jun 25, 2024
Member
gsmet
left a comment
gsmet
left a comment
There was a problem hiding this comment.
OK. Let's see how it goes then :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.