Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register java.sql.*isClosed methods for reflection #41257

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jun 17, 2024

These methods are reflectively accessed starting with GraalVM for JDK
23, due to https://bugs.openjdk.org/browse/JDK-8229959 AFAIU.

Resolves errors in integration tests, see https://github.com/graalvm/mandrel/actions/runs/9540048142/job/26291954634#step:12:608

These methods are reflectively accessed starting with GraalVM for JDK
23, due to https://bugs.openjdk.org/browse/JDK-8229959 AFAIU.
Copy link

quarkus-bot bot commented Jun 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8b90462.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit 21a2ccf into quarkusio:main Jun 17, 2024
42 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 17, 2024
@zakkak zakkak deleted the 2024-06-17-fix-agroal-isclosed-accesses branch June 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants