Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI guide to show version dynamically #41191

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Jun 13, 2024

Going through CLI Guide I saw that the old Quarkus version is used. This will add defined Quarkus version but probably only drawback is that in guides on https://quarkus.io/version/main/guides/ will be always 999-SNAPSHOT and not specific version.

If you want I can just update hardcoded version.

Also building the docs it throw warning that id is missing so I add it.

This comment has been minimized.

Copy link

github-actions bot commented Jun 13, 2024

😭 Deploy PR Preview failed.

@michalvavrik michalvavrik requested a review from gsmet June 13, 2024 19:54
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely convinced this is a good move.

This is about adding an alias a very specific version, not the latest so I don't really think it's a problem to point to an older version.

@jedla97
Copy link
Contributor Author

jedla97 commented Jun 14, 2024

I'll leave the decision up to you. Feel free close this PR.

Mainly for me why I create this was that I read 3.11 guide and see usage of 3.5.0 version. From my POV I would have the actual released version rather then old one.

@gsmet
Copy link
Member

gsmet commented Jun 14, 2024

If you want to use the actual version, you wont create an alias with a very specific version. We could adjust to use a LTS version instead of 3.5.0 but the point of this paragraph is to show how you can pinpoint a version.

So I would rather change it to 3.8.5 rather than to the current version.

@jedla97 jedla97 force-pushed the fix-cli-docs branch 2 times, most recently from 8535428 to 89b00e6 Compare June 17, 2024 18:35
@jedla97
Copy link
Contributor Author

jedla97 commented Jun 17, 2024

Sorry for late update, I update it to 3.8.5

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted things a little bit and it looks good to go.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 22, 2024
Copy link

quarkus-bot bot commented Oct 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9f53ef8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Oct 22, 2024

🙈 The PR is closed and the preview is expired.

@gsmet gsmet merged commit 43bd76f into quarkusio:main Oct 23, 2024
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 23, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants