-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CLI guide to show version dynamically #41191
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced this is a good move.
This is about adding an alias a very specific version, not the latest so I don't really think it's a problem to point to an older version.
I'll leave the decision up to you. Feel free close this PR. Mainly for me why I create this was that I read 3.11 guide and see usage of 3.5.0 version. From my POV I would have the actual released version rather then old one. |
If you want to use the actual version, you wont create an alias with a very specific version. We could adjust to use a LTS version instead of So I would rather change it to |
8535428
to
89b00e6
Compare
Sorry for late update, I update it to 3.8.5 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted things a little bit and it looks good to go.
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
Going through CLI Guide I saw that the old Quarkus version is used. This will add defined Quarkus version but probably only drawback is that in guides on https://quarkus.io/version/main/guides/ will be always
999-SNAPSHOT
and not specific version.If you want I can just update hardcoded version.
Also building the docs it throw warning that id is missing so I add it.