-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR about the usage of the TLS registry in client extensions establishing TLS connection #41126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Jun 11, 2024
cescoffier
force-pushed
the
tls-registry-client-adr
branch
from
June 11, 2024 15:23
e6cccbb
to
63e0b12
Compare
geoand
reviewed
Jun 11, 2024
@geoand As you did the exercise, is there anything I forgot to mention? |
Will let you know in a few minutes once I've read the whole thing :) |
geoand
reviewed
Jun 11, 2024
geoand
reviewed
Jun 11, 2024
geoand
reviewed
Jun 11, 2024
geoand
reviewed
Jun 11, 2024
geoand
reviewed
Jun 11, 2024
Read it all, nothing missing that I can think of! |
…hing TLS connection
cescoffier
force-pushed
the
tls-registry-client-adr
branch
from
June 12, 2024 06:18
63e0b12
to
bc04005
Compare
geoand
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41042.