Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Functions HTTP: use utf-8 instead of default charset decoding request #40673

Merged
merged 1 commit into from
May 17, 2024

Conversation

Nithanim-Work
Copy link

@Nithanim-Work Nithanim-Work commented May 16, 2024

This change removes the implicit usage of the default charset when decoding the request from the incoming Azure Functions invocation. It now always decodes the payload as UTF-8, which should match the grpc passing which is used internally in Azure.
Fix #36973

@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@Nithanim-Work Nithanim-Work changed the title Azure Functions HTTP: use utf-8 instead of default charset decoding request (fixes #36973) Azure Functions HTTP: use utf-8 instead of default charset decoding request May 16, 2024
@gsmet gsmet requested a review from patriot1burke May 16, 2024 12:40
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bfb73c7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 1b085b9 into quarkusio:main May 17, 2024
19 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 17, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 17, 2024
@gsmet
Copy link
Member

gsmet commented May 17, 2024

Thanks for the fix!

@Nithanim-Work
Copy link
Author

@gsmet Thank you for your hard work!

@gsmet gsmet modified the milestones: 3.12 - main, 3.10.2 May 21, 2024
@gsmet gsmet modified the milestones: 3.10.2, 3.8.5 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Functions Http: corrupted request body
4 participants