Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkiverse-parent to 16 and maven-compiler-plugin to 3.13.0 #40541

Merged
merged 1 commit into from
May 10, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented May 9, 2024

  • Bumps the quarkiverse-parent to 16
  • Bumps the maven-compiler-plugin to 3.13.0

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels May 9, 2024
@gastaldi gastaldi requested a review from gsmet May 9, 2024 20:08
@gastaldi gastaldi requested a review from geoand May 9, 2024 20:51

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented May 10, 2024

I force pushed to fix the snapshot issue.

@gastaldi
Copy link
Contributor Author

Thank you @gsmet

Copy link

quarkus-bot bot commented May 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 89c6a70.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/websockets-next/deployment

io.quarkus.websockets.next.test.client.ClientEndpointTest.testClient - History

  • Index 1 out of bounds for length 1 - java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
	at java.base/java.util.concurrent.CopyOnWriteArrayList.elementAt(CopyOnWriteArrayList.java:385)
	at java.base/java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:398)
	at io.quarkus.websockets.next.test.client.ClientEndpointTest.testClient(ClientEndpointTest.java:53)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:499)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:413)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/websockets-next/deployment

io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLo - History

  • Messages: [c2:client1] ==> expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Messages: [c2:client1] ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.assertBroadcast(BroadcastOnOpenTest.java:101)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLo(BroadcastOnOpenTest.java:40)

@gsmet
Copy link
Member

gsmet commented May 10, 2024

@mkouba these websockets-next tests look unstable.

@gsmet gsmet merged commit eff6000 into quarkusio:main May 10, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 10, 2024
@gastaldi gastaldi deleted the bump_versions branch May 10, 2024 14:29
@mkouba
Copy link
Contributor

mkouba commented May 10, 2024

@mkouba these websockets-next tests look unstable.

@gsmet I'll take a look. The BroadcastOnOpenTest failures on Windows are not new but I cannot say I know why 🤷. The ClientEndpointTest is got added recently, so that can be a problem in the test.

@gsmet
Copy link
Member

gsmet commented May 10, 2024

@mkouba for the first one, if we don't think we can find a solution soon, maybe let's disable it on Windows?

@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
@gsmet gsmet modified the milestones: 3.10.1, 3.8.5 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants