Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MINIMUM working mandrel/graalvm version to 22.3 #39877

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Bump MINIMUM working mandrel/graalvm version to 22.3 #39877

merged 1 commit into from
Apr 4, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Apr 4, 2024 •
edited
Loading

Follow up to #37828 (comment) and #39866 (comment)

main tested with 22.3 in https://github.com/graalvm/mandrel/actions/runs/8552569916 (except for integration-test/main due to graalvm/mandrel#708)

@quarkus-bot quarkus-bot bot added the area/core label Apr 4, 2024
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 4, 2024
@geoand
Copy link
Contributor

geoand commented Apr 4, 2024

Do you really think we should backport this?

cc @gsmet

@zakkak
Copy link
Contributor Author

zakkak commented Apr 4, 2024 •
edited
Loading

I think so.

22.2 is not working with either Quarkus 3.8.x or 3.9.x and it seems a pretty safe change.

@geoand
Copy link
Contributor

geoand commented Apr 4, 2024

Gotcha, thanks

gsmet
gsmet approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm all for backporting this and being a bit more aggressive.

Things can get very weird with versions of GraalVM that we are not fully testing and there's nothing the typical user can do to work around it and continue using the old version.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1b6033b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit df43e7d into quarkusio:main Apr 4, 2024
49 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 4, 2024
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 4, 2024
@zakkak zakkak deleted the 2024-04-04-bump-minimum-mandrel-version branch April 5, 2024 06:17
@gsmet gsmet modified the milestones: 3.10 - main, 3.9.3 Apr 9, 2024
@gsmet gsmet modified the milestones: 3.9.3, 3.8.4 Apr 9, 2024
@gsmet gsmet modified the milestones: 3.8.4, 3.9.3 Apr 11, 2024
@gsmet gsmet modified the milestones: 3.9.3, 3.8.5 May 15, 2024
@zakkak zakkak mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.8.5
Development

Successfully merging this pull request may close these issues.
4 participants
@zakkak @geoand @jerboaa @gsmet