-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keycloak Authorization dynamic tenant config resolution #39643
Add Keycloak Authorization dynamic tenant config resolution #39643
Conversation
michalvavrik
commented
Mar 22, 2024
•
edited by geoand
Loading
edited by geoand
- Closes: Dynamic Keycloak Policy Enforcer for multi-tenancy #25774
- Closes: Support the dynamic KeycloakPolicyEnforcerAuthorizer tenants #17664
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
hey @pedroigor please review if you would like, otherwise in terms of what is changed, changes are not specific to Keycloak (it's a CDI feature...), so @sberyozkin is right reviewer for this. |
af3c7d6
to
56072ca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
051b04b
to
c998c60
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c998c60
to
1789d1a
Compare
@sberyozkin I pushed it by accident as I need to fix some tests, docs and write more tests, but as it's already there, you can look at the builder and provide early feedback. Or not. Anyway, it's as compact as I could make it. Cheers. |
This comment has been minimized.
This comment has been minimized.
1789d1a
to
96f0b5c
Compare
Done, the |
96f0b5c
to
a4a1aa6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @michalvavrik, can you please type a builder sequence showing all the supported properties being set, I was not sure about |
a4a1aa6
to
9a6ad0e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...-authorization/runtime/src/main/java/io/quarkus/keycloak/pep/TenantPolicyConfigResolver.java
Outdated
Show resolved
Hide resolved
...-authorization/runtime/src/main/java/io/quarkus/keycloak/pep/TenantPolicyConfigResolver.java
Outdated
Show resolved
Hide resolved
...loak-authorization/runtime/src/main/java/io/quarkus/keycloak/pep/PolicyEnforcerResolver.java
Show resolved
Hide resolved
9a6ad0e
to
cb558a3
Compare
This comment has been minimized.
This comment has been minimized.
cb558a3
to
80f2fbc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ping @sberyozkin |
80f2fbc
to
268049b
Compare
I've rebased on the current main and resolved merge conflicts just in case @sberyozkin find a time to review. |
This comment has been minimized.
This comment has been minimized.
@sberyozkin please have a look; I won't resolve merge conflicts again as I'm bit worried it's wasting of CI resources. Will do it when you find a time for this |
268049b
to
24aef29
Compare
Merge conflicts were about TLS registry, the rest of this PR still applies. Resolved. |
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik , let's do it and start planning doing something similar for OIDC 🙂
Cheers Sergey