Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: enable configuration of supported subprotocols #39624

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 21, 2024

  • add WebSocketConnection#subprotocol() that can be used to obtain the subprotocol selected by the handshake
  • the values defined with quarkus.websockets-next.supported-subprotocols contribute to the set of subprotocols passed to the HTTP server configuration
  • also add constants for handshake headers defined by the RFC
  • resolves WebSockets Next: add convenient way to handle the subprotocol header #39465

- add WebSocketConnection#subprotocol() that can be used to obtain the
subprotocol selected by the handshake
- the values defined with quarkus.websockets-next.supported-subprotocols
contribute to the set of subprotocols passed to the HTTP server
configuration
- also add constants for handshake headers defined by the RFC
- resolves quarkusio#39465
@mkouba mkouba requested a review from cescoffier March 21, 2024 16:04
import io.vertx.core.http.HttpServerOptions;

@Dependent
public class WebSocketHttpServerOptionsCustomizer implements HttpServerOptionsCustomizer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

Copy link

quarkus-bot bot commented Mar 21, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 548a49c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 26dd881 into quarkusio:main Mar 22, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 22, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSockets Next: add convenient way to handle the subprotocol header
2 participants