Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProfileManager #39194

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

radcortez
Copy link
Member

No description provided.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4c2550a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@radcortez radcortez requested a review from geoand May 3, 2024 10:03
@geoand
Copy link
Contributor

geoand commented May 5, 2024

I am wondering if there are any extensions in the Platform or the Quarkiverse that use it... Do you have any idea?

@radcortez
Copy link
Member Author

Unsure, but the main method has been deprecated for a while with a pointer to use the new one, especially because the old one doesn't support multiple profiles.

@geoand
Copy link
Contributor

geoand commented May 6, 2024

What version did we deprecate it in? Do you remember?

@radcortez
Copy link
Member Author

2.16 :D

#28091

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, kill it!

@radcortez radcortez merged commit fb12a4d into quarkusio:main May 7, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 7, 2024
@rsvoboda
Copy link
Member

rsvoboda commented May 9, 2024

@radcortez / @geoand is this something to highlight in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.11?

https://github.com/search?q=io.quarkus.runtime.configuration.ProfileManager&type=code shows some hits, e.g. Keycloak and apicurio-registry

@Pepo48
Copy link

Pepo48 commented May 9, 2024

+1 for this to be mentioned in the migration guide.

Jfyi, I can confirm that this is something that will need to be addressed in Keycloak. It already broke our last night's CI run with quarkus-nightly (that's actually the reason I found this PR in the first place) 😊.

@radcortez
Copy link
Member Author

radcortez commented May 10, 2024

Ok, added the following text:

Removed deprecated ProfileManager#getActiveProfile and ProfilaManger. The ProfileManager could not handle multiple profiles, added in Quarkus 2.16. To retrieve the active profile, please use io.quarkus.runtime.configuration.ConfigUtils#getProfiles. The configuration name used to retrieve the Quarkus profile cannot be appropriately determined by a simple constant definition (as it was in ProfileManager); if you need it, please use LaunchMode.current().getProfileKey().

@Pepo48
Copy link

Pepo48 commented May 10, 2024

if you need it, please use LaunchMode.current().getProfileKey()

@radcortez I assume that ProfileManager.getLaunchMode().getProfileKey() is just another way of achieving the suggested, right?

@radcortez
Copy link
Member Author

Yes, but that one will also get removed, so please use LaunchMode.current().getProfileKey().

@Pepo48
Copy link

Pepo48 commented May 10, 2024

@radcortez got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants