Remove ProfileManager

[radcortez]

No description provided.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4c2550a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[geoand]

I am wondering if there are any extensions in the Platform or the Quarkiverse that use it... Do you have any idea?

[radcortez]

Unsure, but the main method has been deprecated for a while with a pointer to use the new one, especially because the old one doesn't support multiple profiles.

[geoand]

What version did we deprecate it in? Do you remember?

[radcortez]

2.16 :D

#28091

[geoand]

In that case, kill it!

[rsvoboda]

@radcortez / @geoand is this something to highlight in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.11?

https://github.com/search?q=io.quarkus.runtime.configuration.ProfileManager&type=code shows some hits, e.g. Keycloak and apicurio-registry

[Pepo48]

+1 for this to be mentioned in the migration guide.

Jfyi, I can confirm that this is something that will need to be addressed in Keycloak. It already broke our last night's CI run with quarkus-nightly (that's actually the reason I found this PR in the first place) 😊.

[radcortez]

Ok, added the following text:

Removed deprecated ProfileManager#getActiveProfile and ProfilaManger. The ProfileManager could not handle multiple profiles, added in Quarkus 2.16. To retrieve the active profile, please use io.quarkus.runtime.configuration.ConfigUtils#getProfiles. The configuration name used to retrieve the Quarkus profile cannot be appropriately determined by a simple constant definition (as it was in ProfileManager); if you need it, please use LaunchMode.current().getProfileKey().

[Pepo48]

if you need it, please use LaunchMode.current().getProfileKey()

@radcortez I assume that ProfileManager.getLaunchMode().getProfileKey() is just another way of achieving the suggested, right?

[radcortez]

Yes, but that one will also get removed, so please use LaunchMode.current().getProfileKey().

[Pepo48]

@radcortez got it, thanks!