Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More documentation adjustments for new downstream tooling #38648

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 7, 2024

@MichalMaler I think this should address your latest concerns.

@MichalMaler
Copy link
Contributor

@gsmet Hello!
Happy to test it as soon as it is merged. :)
Thank you.

@gsmet gsmet requested a review from gastaldi February 7, 2024 16:09
Copy link

quarkus-bot bot commented Feb 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cdd343f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1018)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:832)

@gsmet gsmet merged commit ff8d73c into quarkusio:main Feb 7, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 7, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.2 Feb 7, 2024
@gsmet
Copy link
Member Author

gsmet commented Feb 7, 2024

@MichalMaler I merged it to main, is it enough for you to test?

@MichalMaler
Copy link
Contributor

@gsmet I will start testing the RHBQ 3.8 docs on the main tomorrow.
Regarding the backport, however, if that will not be a big struggle, I would welcome this to be part of the 3.2, too, but only in a situation where the absence of this mighty fix could bring us trouble. I know you fixed the files directly, and this is an additional assurance.
3.2 is now a safe haven for us, and it would be great to move to main and a larger sample of files when we have fully fixed and debugged the previous release, and with a caution that we can safely use the down-streaming pipeline for 3.2 if needed, even though I would rather not to touch that branch anymore and focus more on the future; but it can of course happen.

@gsmet gsmet modified the milestones: 3.7.2, 3.2.11.Final Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants