Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply more fixes the Locales IT #38282

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Apply more fixes the Locales IT #38282

merged 3 commits into from
Jan 18, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 18, 2024

No description provided.

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can understand this looks good to me.

CI is not happy though...

This comment has been minimized.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this accidentally added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added because in the future if the tests actually test anything (by attempting to hit an endpoint), they won't work without this

@gastaldi gastaldi requested a review from famod January 18, 2024 15:59
Copy link

quarkus-bot bot commented Jan 18, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit ed921c8 into quarkusio:main Jan 18, 2024
18 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 18, 2024
@geoand geoand deleted the more-locales-it branch January 18, 2024 16:04
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants