-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update native configuration file best practices #38186
Update native configuration file best practices #38186
Conversation
🙈 The PR is closed and the preview is expired. |
Is this related to #38118? |
Yes, IMO we need a combination of these two PRs. |
No it's not. This PR is the result of my own experiments. |
@zakkak exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #38118 (review)
@galderz it looks like @dliubars updated #38118 and it now only includes the following changes (i.e. it no longer suggests using experimental options) which are currently missing from this PR:
- replace references to resources-config.json with resource-config.json
- replace references to reflection-config.json with reflect-config.json
I suggest you either:
- merge Rename reflection-config.json into reflect-config.json and resources-config.json into resource-config.json #38118 and rebase this PR
or - cherry-pick @dliubars commit (e911584) in your branch
* Update to promote best ways to use custom configuration files.
6dc75f3
to
ff63dd6
Compare
I merged #38118 and I've now rebased this PR with the changes there. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just added a suggestion that IMO makes the corresponding sentence a bit easier to read.
Co-authored-by: Foivos <[email protected]>
Status for workflow
|
Placing custom configuration files in
META-INF/native-image/<group-id>/<artifact-id>
is the best way. It doesn't get in the way of what Quarkus generates, works out of the box without additional configuration and does not produce any native build warnings. Alternative methods have been removed to avoid confusion.