-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit security-proactive-authentication.adoc #37851
Conversation
🙈 The PR is closed and the preview is expired. |
@rolfedh Is this one good to go or we are waiting for at least one more review from Michal or Sheila ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rolfedh,
Great job. I have no comments. All LGTM.
@rolfedh Michal's suggestions look good to me, so please ask someone else from the team to merge it once they are applied |
@geoand: For this team, what is the customary way to indicate that a PR is ready for merge? I want to make sure I do it correctly to avoid generating noise for the maintainers. |
Usually when we know we are starting something that is work is progress, we make it a draft and then mark it as ready for review when we think we're done |
Thanks @geoand. I believe this document has been reviewed and is ready for merge. If I understand correctly, I'll wait for a maintainer to merge it. No action required on my part. |
👌 |
References https://issues.redhat.com/browse/QDOCS-563