Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit security-proactive-authentication.adoc #37851

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Edit security-proactive-authentication.adoc #37851

merged 1 commit into from
Jan 6, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Dec 19, 2023

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Dec 19, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh mentioned this pull request Dec 20, 2023
Open
@sberyozkin sberyozkin self-requested a review January 4, 2024 16:15
@sberyozkin
Copy link
Member

@rolfedh Is this one good to go or we are waiting for at least one more review from Michal or Sheila ?

sheilamjones
sheilamjones approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@sheilamjones sheilamjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rolfedh,
Great job. I have no comments. All LGTM.

@sberyozkin
Copy link
Member

@rolfedh Michal's suggestions look good to me, so please ask someone else from the team to merge it once they are applied

@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 5, 2024 •
edited
Loading

@geoand: For this team, what is the customary way to indicate that a PR is ready for merge? I want to make sure I do it correctly to avoid generating noise for the maintainers.

@geoand
Copy link
Contributor

geoand commented Jan 5, 2024 •
edited
Loading

Usually when we know we are starting something that is work is progress, we make it a draft and then mark it as ready for review when we think we're done

@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 5, 2024

Thanks @geoand. I believe this document has been reviewed and is ready for merge. If I understand correctly, I'll wait for a maintainer to merge it. No action required on my part.

@geoand geoand merged commit c98bd6d into quarkusio:main Jan 6, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 6, 2024
@geoand
Copy link
Contributor

geoand commented Jan 6, 2024

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

@MichalMaler MichalMaler MichalMaler approved these changes

@sheilamjones sheilamjones sheilamjones approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Quarkus Documentation
Status: Done
Milestone
3.7.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@rolfedh @sberyozkin @geoand @MichalMaler @sheilamjones