Move baseline from Java 11 to Java 17

[gsmet]

Creating as draft as I want a full CI run in my fork and because things are still in discussion.

We will need to check that Ecosystem CI is ready for this too, and probably a few other things like Quickstarts CI.

[gsmet]

@aloubyansky I added two comments to your attention. There's something odd with the Maven plugins.

[gsmet]

@aloubyansky there's something odd here. If I remove these lines and default to the parent Java 17, I end up with the following error when running the tests (basically anything trying to use the plugin fails):

(I have the same problem with the quarkus-maven-plugin, will post the exact error message below)

[ERROR]   ExtensionDescriptorMojoTest.shouldExecuteSimplePomCleanly:73->makeMojo:250->AbstractMojoTestCase.lookupConfiguredMojo:461->PlexusTestCase.lookup:205 » ComponentLookup com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) No implementation for BootstrapWorkspaceProvider was bound.
  while locating ExtensionDescriptorMojo
  at ClassRealm[plexus.core, parent: null]
      \_ installed by: WireModule -> PlexusBindingModule
  while locating Mojo annotated with @Named("io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor")

1 error

======================
Full classname legend:
======================
BootstrapWorkspaceProvider: "io.quarkus.maven.BootstrapWorkspaceProvider"
ExtensionDescriptorMojo:    "io.quarkus.maven.ExtensionDescriptorMojo"
Mojo:                       "org.apache.maven.plugin.Mojo"
Named:                      "com.google.inject.name.Named"
PlexusBindingModule:        "org.eclipse.sisu.plexus.PlexusBindingModule"
WireModule:                 "org.eclipse.sisu.wire.WireModule"
========================
End of classname legend:
========================

[gsmet]

@aloubyansky If I drop these lines and default to the parent Java 17, I end up with the following error when anything tries to use this plugin:

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:generate-code (default) on project quarkus-integration-test-grpc-descriptor-sets-parent: Execution default of goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:generate-code failed: Unable to load the mojo 'generate-code' (or one of its required components) from the plugin 'io.quarkus:quarkus-maven-plugin:999-SNAPSHOT': com.google.inject.ProvisionException: Unable to provision, see the following errors:
[ERROR]
[ERROR] 1) No implementation for QuarkusBootstrapProvider was bound.
[ERROR]   while locating GenerateCodeMojo
[ERROR]   at ClassRealm[plugin>io.quarkus:quarkus-maven-plugin:999-SNAPSHOT, parent: ClassLoaders$AppClassLoader@251a69d7]
[ERROR]       \_ installed by: WireModule -> PlexusBindingModule
[ERROR]   while locating Mojo annotated with @Named("io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:generate-code")
[ERROR]
[ERROR] 1 error
[ERROR]
[ERROR] ======================
[ERROR] Full classname legend:
[ERROR] ======================
[ERROR] ClassLoaders$AppClassLoader: "jdk.internal.loader.ClassLoaders$AppClassLoader"
[ERROR] GenerateCodeMojo:            "io.quarkus.maven.GenerateCodeMojo"
[ERROR] Mojo:                        "org.apache.maven.plugin.Mojo"
[ERROR] Named:                       "com.google.inject.name.Named"
[ERROR] PlexusBindingModule:         "org.eclipse.sisu.plexus.PlexusBindingModule"
[ERROR] QuarkusBootstrapProvider:    "io.quarkus.maven.QuarkusBootstrapProvider"
[ERROR] WireModule:                  "org.eclipse.sisu.wire.WireModule"
[ERROR] ========================
[ERROR] End of classname legend:
[ERROR] ========================
[ERROR] 

[aloubyansky]

Would it work with maven.compiler.target=11?

[gsmet]

I suppose it could but I'm very surprised we can't push Java 17 bytecode here.

[github-actions]

🙈 The PR is closed and the preview is expired.