-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to Configuration section of the Logging guide #35988
Conversation
I don't have time to review new text. We need just the fix. |
Text is almost the same. I asked @jmartisk for a sanity check that I didn't change the meaning. |
Then I'm leaving it to him. |
🙈 The PR is closed and the preview is expired. |
@jmartisk @cescoffier The GitHub Quarkus preview bot provides a nice and working asciidoc pass macro rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second what @Ladicek said.
Please fix the reported issue and avoid changing the content in a way that requires a closer review.
I have no idea what you mean by quarkus.log.console.pass:c,a[*]
and really this fix should be straightforward and shouldn't need an extensive review and discussions.
a99edf5
to
423d4a8
Compare
423d4a8
to
dc85af1
Compare
It is already reviewed by @cescoffier and @jmartisk . What I am using is the simple Asciidoc escape macro that I am using when My second commit I already squashed solve this by different structure, thus the escape macro is not needed (since there is nothing to escape now). This small PR is fixing the problem with badly rendered asciidoc escape and provide more value trough better examples. @gsmet Please, dont block the progress of this PR to be merged and backported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I don't know much about Asciidoc so I'm not gonna dismiss the blocking review
The asciidoc passes are no longer needed, since I removed the whole text they were needed for. |
Yeah, I understand, but since this is not my field of expertise, I am not willing to dismiss concerns that others might have. If this were one of my things, I agreed with the change and I thought others concerns were either satisfied or not important enough to block the progress, I would dismiss the blocking review |
dc85af1
to
8cd97c3
Compare
Rewording the chapter about logging categories Adding examples for the better context Signed-off-by: Michal Maléř <[email protected]>
8cd97c3
to
9ad855f
Compare
@MichalMaler well, next time, please don't ask me for a review on Zulip then. I really have better things to do. |
I will choose to answer in a slightly different tone. I kindly asked for your opinion 5 hours ago before creating this PR. An application of asciidoc macro that is visible in the code was something I wanted to discuss with you briefly. As you wish, I will not ask you for a review again. Have a great day, G. |
Fixing the badly rendered asciidoc markup that should provide an escape on used asterixes. In my local build, this worked perfectly fine, but for some reasons, it is not rendere as expected on Quarkus portal (main snapshot)
Bad asciidoc translation
Expected asciidoc translation
To fix this, I wanted to use
pass:[]
asciidoc macro that would allow me to use*
in the backtick and render properly (no bold in the text, not escape macro leftovers). The\
and++
escape approaches weren't rendered properly, so I used thepass[]
macro as my last resort.I also wanted to reword the sentence slightly and put it in a bullet list:
However, after consulting this with SME, we agreed on removing these handlers examples completely and replace then with the contextually correct examples (root and per-category) that better fits the overall context of this chapter.