Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: introduce InjectableFragment #35841

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Qute: introduce InjectableFragment #35841

merged 1 commit into from
Sep 13, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 11, 2023

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Sep 11, 2023
@mkouba mkouba mentioned this pull request Sep 11, 2023
Closed
FroMage
FroMage approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked it as approve just to avoid having to re-review for a typo, but look great ;)

extensions/qute/runtime/src/main/java/io/quarkus/qute/runtime/TemplateProducer.java Outdated Show resolved Hide resolved
@mkouba
Qute: introduce InjectableFragment
a35aa5e 
- type-safe fragments should honor the selected variant
- fixes quarkiverse/quarkus-renarde#165
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 11, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 12, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 3eaf30e into quarkusio:main Sep 13, 2023
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 13, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/qute The template engine
Projects
None yet
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.

Wrong Content-Type header when using fragments
2 participants
@mkouba @FroMage