Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.3 backports 1 #35091

Merged
merged 38 commits into from
Jul 29, 2023
Merged

3.2.3 backports 1 #35091

merged 38 commits into from
Jul 29, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 28, 2023

Please don't merge, I will merge it myself.

jsmrcka and others added 30 commits July 28, 2023 17:57
Fix event type.

(cherry picked from commit 6ac3b3e)
This is useful when we want to restart a failed build. It usually
happens in the next few days and we need the artifact to be around.

(cherry picked from commit e39263d)
We know properly report the root path
whereas previously it was being ignored

Fixes: quarkusio#34778
(cherry picked from commit aa2a35a)
Signed-off-by: Phillip Kruger <[email protected]>
(cherry picked from commit 2ab4057)
This should fix a problem in downstream documentation and it doesn't
hurt.

(cherry picked from commit d934496)
RabbitMQ 3.9 is out of general support. This updates the dev services container to 3.12 series.

It also fixes a copy/paste error I made long ago.

(cherry picked from commit 32dfdd5)
There were two issues:
- The resources were not found when using the container image openshift and container image s2i.
- The resources were not found at installing them in the cluster.

Fix quarkusio#34673

(cherry picked from commit 7357d78)
Relates to: quarkusio#34934

(cherry picked from commit b87954f)
…n with name 'annotationProcessor' not found" problem.

fixes quarkusio#32767

(cherry picked from commit 9f832ee)
Quarkus enables the inclusion or exclusion of Jakarta REST Resources, Providers and Features directly thanks to build time conditions in the same that it does for CDI beans.
Thus, the REST Data with Panache interfaces can be annotated with profile conditions (`@io.quarkus.arc.profile.IfBuildProfile` or `@io.quarkus.arc.profile.UnlessBuildProfile`) and/or with property conditions (`io.quarkus.arc.properties.IfBuildProperty` or `io.quarkus.arc.properties.UnlessBuildProperty`) to indicate to Quarkus at build time under which conditions the generated Jakarta REST classes should be included.

In the following example, Quarkus will include the generated resource from the `PeopleResource` interface if and only if the build profile `app1` has been enabled.

```java
@IfBuildProfile("app1")
public interface PeopleResource extends PanacheEntityResource<Person, Long> {
}
```

=== Using a runtime property

IMPORTANT: This option is only available when using the RESTEasy Reactive Quarkus extension.

Quarkus can also conditionally disable the generated Jakarta REST Resources based on the value of runtime properties using the `@io.quarkus.resteasy.reactive.server.EndpointDisabled` annotation.

In the following example, Quarkus will exclude the generated resource from the `PeopleResource` interface at runtime if the application has `some.property` configured to `"disable"`.

```java
@EndpointDisabled(name = "some.property", stringValue = "disable")
public interface PeopleResource extends PanacheEntityResource<Person, Long> {
}
```

Fix quarkusio#34938

(cherry picked from commit 1f85a3c)
Before these changes, the resource requirements limits/requests were ignored for the sidecars containers.

Note that these changes include a workaround for dekorateio/dekorate#1234.

Fix quarkusio#35006

(cherry picked from commit 5312cd3)
... when using the `quarkus.kubernetes.output-directory`.

In gradle, when users set the output-directory property, the K8s resources were generated at `$HOME/.gradle/workers`.

I tried these changes in Maven and Gradle and now, it works.

Fix quarkusio#34827

(cherry picked from commit 3ee917b)
There should be a "joined" message on user joining,
but no message is acctually sent.

No "ready" message is generated on user joining,
so move this message to user incoming.

(cherry picked from commit f6c54f4)
(cherry picked from commit a215b60)
…cturing according to the diataxis framework

(cherry picked from commit 41da754)
(cherry picked from commit dad6e5a)
(cherry picked from commit 16d067d)
MichalMaler and others added 4 commits July 28, 2023 18:08
Apply suggestions from code review

Co-authored-by: Ladislav Thon <[email protected]>

Signed-off-by: Michal Maléř <[email protected]>
(cherry picked from commit 6abe8c9)
Co-authored-by: Michal Maléř <[email protected]>
(cherry picked from commit b5c545e)
Co-authored by Ladislav Thon

Apply suggestions from code review

Co-authored-by: Michelle Purcell <[email protected]>

Apply suggestions from code review

Co-authored-by: Michelle Purcell <[email protected]>
Co-authored-by: Ladislav Thon <[email protected]>
(cherry picked from commit d77413f)
Signed-off-by: Michal Maléř <[email protected]>
(cherry picked from commit 50d6678)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Jul 28, 2023
@gsmet gsmet self-assigned this Jul 28, 2023
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kubernetes area/logging area/oidc area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/rest area/scheduler area/smallrye area/spring Issues relating to the Spring integration area/tracing labels Jul 28, 2023
@quarkus-bot quarkus-bot bot added the area/hibernate-validator Hibernate Validator label Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 28, 2023

Failing Jobs - Building 87d9902

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Security1 Build ⚠️ Check → Logs Raw logs
Quickstarts Compilation - JDK 17 Compile Quickstarts ⚠️ Check → Logs Raw logs

@gsmet gsmet merged commit bd03bd0 into quarkusio:3.2 Jul 29, 2023
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-validator Hibernate Validator area/infra internal and infrastructure related issues area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kubernetes area/logging area/oidc area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/rest area/scheduler area/smallrye area/spring Issues relating to the Spring integration area/tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.