Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run blocking security tasks from Vert.x duplicated context #35072

Conversation

michalvavrik
Copy link
Member

#34963 follow-up

@quarkus-bot

This comment has been minimized.

@michalvavrik
Copy link
Member Author

michalvavrik commented Jul 28, 2023

I need to check GrpcAuthTest as it most likely related.

@michalvavrik michalvavrik marked this pull request as draft July 28, 2023 09:08
@michalvavrik
Copy link
Member Author

Converted to draft till I finish debugging of gRPC.

@michalvavrik michalvavrik marked this pull request as ready for review July 28, 2023 14:29
@michalvavrik
Copy link
Member Author

Okay, I got it, gRPC is not a problem anymore.

@michalvavrik michalvavrik force-pushed the feature/security-run-blocking-tasks-from-duplicated-ctx branch from 2da5b43 to 48bd965 Compare July 28, 2023 14:33
@sberyozkin
Copy link
Member

Hey @michalvavrik The refactoring looks neat, but I'm just getting a bit disorientated now that I'm preparing for PTO so can't properly review :-). Please ask @stuartwdouglas and @cescoffier to review. Cheers

@michalvavrik michalvavrik removed the request for review from sberyozkin July 28, 2023 15:43
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 28, 2023

Failing Jobs - Building 48bd965

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/mongodb-panache 

📦 integration-tests/mongodb-panache

io.quarkus.it.mongodb.panache.reactive.ReactiveMongodbPanacheResourceTest.testMoreRepositoryFunctionalities line 351 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

@michalvavrik
Copy link
Member Author

I don't think ReactiveMongodbPanacheResourceTest failure on Windows could be related.

@michalvavrik
Copy link
Member Author

Thank you Stuart, I am also adding @cescoffier as Sergey suggested.

@geoand geoand merged commit d2de3f8 into quarkusio:main Aug 1, 2023
46 of 48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 1, 2023
@michalvavrik michalvavrik deleted the feature/security-run-blocking-tasks-from-duplicated-ctx branch August 1, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants