Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --no-dockerfiles command shortcut #34734

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

bogedal
Copy link

@bogedal bogedal commented Jul 13, 2023

No description provided.

@quarkus-bot

This comment was marked as resolved.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus labels Jul 13, 2023
@bogedal bogedal changed the title 🎉 Added support for --no-dockerfiles Added support for --no-dockerfiles 🎉 Jul 13, 2023
@ia3andy
Copy link
Contributor

ia3andy commented Jul 13, 2023

There is an easier way, I think it's just a bug that it doesn't work. I'll have a look on monday, tomorrow is holiday in France.

@bogedal
Copy link
Author

bogedal commented Jul 13, 2023

@ia3andy Have a good one tomorrow and we'll see on monday which way you choose 👍

@bogedal
Copy link
Author

bogedal commented Jul 14, 2023

@ia3andy From a users point of view I must admit I would argue that the --no-dockerfiles is the better solution.
I think it fits well with the two other options --no-code and --no-wrapper.
--no-code will affect beginning state of the app
--no-wrapper will affect how to build
--no-dockerfiles would affect how to run

From a readability standpoint I think --no-dockerfiles is better over -Dcodegen.no-dockerfiles as well.
Also the -D option is used for various other things like jvm-args.

@geoand geoand changed the title Added support for --no-dockerfiles 🎉 Added support for --no-dockerfiles Jul 14, 2023
@bogedal bogedal requested a review from ebullient July 17, 2023 04:07
@ia3andy
Copy link
Contributor

ia3andy commented Jul 17, 2023

Hey @bogedal, so in the end this was working right? This PR introduces a new shortcut option name?

@bogedal
Copy link
Author

bogedal commented Jul 17, 2023

Hey @bogedal, so in the end this was working right? This PR introduces a new shortcut option name?

Yes - this enables the use of the option --no-dockerfiles, which works like --no-code and --no-wrapper.

@ia3andy ia3andy changed the title Added support for --no-dockerfiles Added --no-dockerfiles command shortcut Jul 17, 2023
@quarkus-bot

This comment has been minimized.

@ia3andy
Copy link
Contributor

ia3andy commented Jul 18, 2023

could you squash you commits to one commit please:
https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 18, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@ebullient ebullient dismissed their stale review July 19, 2023 01:55

my issue was addressed. ;)

@ebullient ebullient merged commit b9449e5 into quarkusio:main Jul 19, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants