-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --no-dockerfiles command shortcut #34734
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There is an easier way, I think it's just a bug that it doesn't work. I'll have a look on monday, tomorrow is holiday in France. |
@ia3andy Have a good one tomorrow and we'll see on monday which way you choose 👍 |
@ia3andy From a users point of view I must admit I would argue that the --no-dockerfiles is the better solution. From a readability standpoint I think --no-dockerfiles is better over -Dcodegen.no-dockerfiles as well. |
devtools/cli/src/test/java/io/quarkus/cli/CliProjectGradleTest.java
Outdated
Show resolved
Hide resolved
Hey @bogedal, so in the end this was working right? This PR introduces a new shortcut option name? |
Yes - this enables the use of the option --no-dockerfiles, which works like --no-code and --no-wrapper. |
This comment has been minimized.
This comment has been minimized.
could you squash you commits to one commit please: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
No description provided.