Enable Gradle Enterprise build cache #34597
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
quarkus-bot
bot
added
the
area/infra-automation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
quarkus-bot
bot
added
the
area/dependencies
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
In case we have an issue with the bot, it's interesting to have a summary in the workflow report.
The config from the global parent should be preferred.
The annotation processor produces output in the root target directory for the config reference and they are all stored in one big directory which makes it hard for us to declare them as outputs. We need to reorganize this for it to work.
…nsions" This reverts commit 640b26c.
Goal execution marked as not cacheable: Build caching was not enabled for this goal execution because the following parameters were not handled: [session].
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Changes looks good.
There is no description in the PR but from what I gather this now adds more useful lables/tags, enables build cache automatically when and only when running in CI (CI env set) - locally you still need to explicitly enable it.
Thus +1 for this.
What I was not sure about is if we always will use the build cache in all CI builds too - like in CI integration. I assume it will - and just wonder what mechanism we have to purge the cache to ensure we have a clean build?
but I'm +1 on enabling it ASAP and see if it brings some surprises.
For now we done everything we could to sanity check it.
LGTM.
This comment has been minimized.
This comment has been minimized.
| <local><enabled>false</enabled></local> | ||
| <remote><enabled>false</enabled></remote> | ||
| <local> | ||
| <enabled>false</enabled> |
There was a problem hiding this comment.
why is the local build cache disabled?
There was a problem hiding this comment.
For now, we only enabled the cache on CI and the containers are all new so I don't think it has any value to enable the local cache.
I will need to fix #35439 to make it possible to enable caching for developers.
|
A lot of thanks to @jprinet @ribafish @runningcode from Gradle, which helped us a lot and did a lot of work to make it possible. |
See the commit messages for everything this PR does.
It enables the Gradle build cache for our CI builds, which should allow us to speed up CI significantly.
A lot of thanks to @jprinet @ribafish @runningcode from Gradle, which helped us a lot and did a lot of work to make it possible.