Remove long deprecated options from CertificateConfig #34540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sure, no problem |
cescoffier
approved these changes
Jul 5, 2023
This comment has been minimized.
This comment has been minimized.
These options where deprecated more than 2 years ago in 272119d
gsmet
force-pushed
the
certificate-config-deprecated
branch
from
4f48afc to
d55e533
Compare
gsmet
approved these changes
Aug 2, 2023
Member
gsmet
left a comment
gsmet
left a comment
There was a problem hiding this comment.
I rebased this PR and fixed the gRPC tests.
Contributor
Author
|
💪 |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options where deprecated more than 2 years ago in 272119d