Ensure large payloads don't affect the invoking thread of a Resource Method #31613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
reviewed
Mar 6, 2023
...time/src/main/java/org/jboss/resteasy/reactive/server/handlers/SwitchToEventLoopHandler.java
Outdated
Show resolved
Hide resolved
Sgitario
approved these changes
Mar 6, 2023
geoand
added
the
triage/waiting-for-ci
|
@stuartwdouglas can you envision any reason why we would not do this? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TwoFX
reviewed
Mar 6, 2023
...time/src/main/java/org/jboss/resteasy/reactive/server/handlers/SwitchToEventLoopHandler.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
#31606
branch
2 times, most recently
from
04c3116 to
be37355
Compare
TwoFX
reviewed
Mar 7, 2023
...src/main/java/org/jboss/resteasy/reactive/server/core/startup/RuntimeResourceDeployment.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
@geoand is it something that should be backported to 2.16 or is it too risky? |
|
I would prefer we don't |
|
Works for me, just wanted to make sure it wasn't an oversight. |
|
👌🏼 |
Failing Jobs - Building ade65b3
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #31606