Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven BuildIT failures #31494

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix maven BuildIT failures #31494

merged 1 commit into from
Mar 1, 2023

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Mar 1, 2023

Context

The dependency stax-api is not compatible with the dependency quarkus-jaxb because both add the same type javax.xml.namespace.QName (from glassfish jaxb). This dependency was added on purpose to validate the parent-first-artifacts property when building projects with these conflicts with Maven.

After this change was merged, the javax. types were replaced by the quarkus-jaxb extension as part of the jakarta migration, but never with the intention of using the default JAXBContext.

Therefore, we need to skip the JaxbContext validation at build time.
Note that in real scenarios, users would need to either exclude glassfish or the stax-api dependency.

This pull request should fix all the CI failures in the latest pull requests.

The dependency `stax-api` is not compatible with the dependency `quarkus-jaxb` because both add the same type `javax.xml.namespace.QName`. This was done on purpose to validate the `parent-first-artifacts` property when building projects with conflicts with Maven, so we need to skip the JaxbContext validation at build time.

This pull request should fix all the CI failures in the latest pull requests.
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 1, 2023

Failing Jobs - Building 42a81a6

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@iocanel
Copy link
Contributor

iocanel commented Mar 1, 2023

Failures do not seem to be related.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I was going to have a look today but I would never have thought this would be the issue. I thought it was related to our latest invoker plugin and Groovy updates.

@gsmet gsmet merged commit cfbb0a4 into quarkusio:main Mar 1, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 1, 2023
@Sgitario Sgitario deleted the fix_buildit branch March 1, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants