ArC fixes for spec compatibility #30509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The failures are not related. |
mkouba
reviewed
Jan 23, 2023
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Types.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Jan 23, 2023
...rojects/arc/tests/src/test/java/io/quarkus/arc/test/name/InvalidNamedInjectionPointTest.java
Show resolved
Hide resolved
mkouba
added
the
triage/waiting-for-ci
The additions in this commit are taken directly from the Weld codebase. They apply in the situation when the required type during dynamic lookup is represented using a `Class` object, while the bean type is represented using `GenericArrayType`.
The additions in this commit are taken directly from the Weld codebase.
In such case, the corresponding zero value must be injected instead.
The specification is clear that field injection points with `@Named` without value should use `@Named(fieldName)` as the qualifier. Other such injection points lead to a definition error.
|
Rebased (and addressed the nitpick 😆). |
Failing Jobs - Building b5d825a
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/grpc/deployment
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 41 more📦 extensions/grpc/deployment✖ |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28558
package-info.classfor@VetoedArcTestContainerto also indexpackage-info.classof all classes in the test bean archiveClass, while the bean array types are instantiated asGenericArrayTypeBeanManager.getReference()implementationnull@Namedwithout value@Namedwithout value should use@Named(fieldName)as the qualifierTo review, it's probably best to look at each commit in isolation. Tests are added, too.