Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce deploy CLI commands #30309

Merged
merged 7 commits into from
Mar 1, 2023
Merged

Introduce deploy CLI commands #30309

merged 7 commits into from
Mar 1, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jan 11, 2023 •
edited
Loading

This pull request exposes the deployment capabilities of Quarkus across all our dev tools (maven, gradle, cli).

Deployment from the CLI

Introduces the deploy command as well as specific subcommands for:

  • kubernetes
    • kind
    • minikube
  • knative
  • openshift

Simililarly to the image commands, it allows users to perform actions without requiring them to modify their pom to bring in the needed extension.

@iocanel iocanel changed the title Introduce deploy CLI commands [wip] - Introduce deploy CLI commands Jan 11, 2023
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/kubernetes area/maven labels Jan 11, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@iocanel iocanel force-pushed the deploy-cli branch 2 times, most recently from 1c2795f to e082c4f Compare January 24, 2023 07:51
@quarkus-bot

This comment has been minimized.

Sign in to view
@iocanel iocanel mentioned this pull request Jan 24, 2023
Closed
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@iocanel iocanel changed the title [wip] - Introduce deploy CLI commands Introduce deploy CLI commands Jan 25, 2023
@iocanel iocanel force-pushed the deploy-cli branch 2 times, most recently from 9971e4c to 5b5d209 Compare February 2, 2023 15:38
@quarkus-bot

This comment has been minimized.

Sign in to view
@iocanel iocanel requested review from geoand and maxandersen February 3, 2023 10:44
geoand
geoand reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting!

I can't comment on the CLI stuff, but the k8s stuff looks nice :)

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 4, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@iocanel
Copy link
Contributor Author

iocanel commented Feb 10, 2023

Seems that the failure is the classic timeout thing. Still, I am a bit reluctant to merge.
@gsmet wdyt?

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@iocanel
Copy link
Contributor Author

iocanel commented Feb 16, 2023

@gsmet, @geoand: the failure seem unrelated what should I do with this pr?

@geoand
Copy link
Contributor

geoand commented Feb 16, 2023

The failure indeed seems unrelated.

+1 for merging

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2023

Failing Jobs - Building 244021e

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 19
✖ Maven Tests - JDK 11 Build Failures Logs Raw logs
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
⌛ Native Tests - Security1 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

@iocanel iocanel merged commit 3ffbd93 into quarkusio:main Mar 1, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 1, 2023
@gsmet gsmet added release/noteworthy-feature and removed triage/needs-rebase This PR needs to be rebased first because it has merge conflicts labels Mar 1, 2023
@gsmet
Copy link
Member

gsmet commented Mar 1, 2023

@iocanel I added the noteworthy-feature label. If you add a comment here with a blurb explaining the feature, I will happily add it to the announcement.

@iocanel
Copy link
Contributor Author

iocanel commented Mar 1, 2023

@iocanel I added the noteworthy-feature label. If you add a comment here with a blurb explaining the feature, I will happily add it to the announcement.

Introduced the ability to `deploy` in all dev tools (cli, maven, gradle). 

This enables the deployment of quarkus application to platforms like kubernetes, knative and openshfit, without requiring changes to the project dependencies or configuration and therefore simplfying developer experience in the cloud.

@gsmet is this what you had in mind?

@gsmet
Copy link
Member

gsmet commented Mar 2, 2023

Yes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@ebullient ebullient ebullient approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

@maxandersen maxandersen Awaiting requested review from maxandersen

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/kubernetes area/maven release/noteworthy-feature
Projects
None yet
Milestone
3.0.0.Alpha5
Development

Successfully merging this pull request may close these issues.
6 participants
@iocanel @maxandersen @geoand @gsmet @aloubyansky @ebullient