Make sure TestMojo resolves test scoped dependencies #30238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
aloubyansky
added
triage/backport-2.13
triage/backport?
and removed
area/maven
area/devtools
geoand
approved these changes
Jan 9, 2023
holly-cummins
added a commit
to holly-cummins/quarkus-pact
that referenced
this pull request
Feb 10, 2023
With the classloading changes in Quarkus 3, it looks like neither quarkusio/quarkus#30238 nor quarkusio/quarkus#30383 are needed (at least for the consumer tests, in the current state).
holly-cummins
added a commit
to holly-cummins/quarkus-pact
that referenced
this pull request
Feb 17, 2023
With the classloading changes in Quarkus 3, it looks like neither quarkusio/quarkus#30238 nor quarkusio/quarkus#30383 are needed (at least for the consumer tests, in the current state).
holly-cummins
added a commit
to quarkiverse/quarkus-pact
that referenced
this pull request
Feb 17, 2023
With the classloading changes in Quarkus 3, it looks like neither quarkusio/quarkus#30238 nor quarkusio/quarkus#30383 are needed (at least for the consumer tests, in the current state).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #quarkiverse/quarkus-pact#28
FYI @holly-cummins