Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move log4j-api to correct quarkus module and add condition for jackson-module-jaxb-annotations registrations #30018

Commits on Dec 23, 2022

  1. Move log4j-api and add-condition for jaxb-annotations registrations

    log4j-api is a dependency of elasticsearch-rest-high-level-client
    
    `log4j-api` is not always present when using the
    elasticsearch-rest-client-common extension as it's not a dependency of
    it. Instead, it is a dependency of elasticsearch-rest-high-level-client:
    
    ```
    +- io.quarkus:quarkus-elasticsearch-rest-high-level-client:jar:999-SNAPSHOT:compile
    |  +- ...
    |  +- org.jboss.logmanager:log4j2-jboss-logmanager:jar:1.1.1.Final:compile
    |  |  \- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
    ```
    
    `com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector` is not
    always present when using the quarkus-jackson extension as it's not a
    dependency of it. Instead, it is a dependency of
    quarkus-resteasy-jackson:
    
    ```
    +- io.quarkus:quarkus-resteasy-jackson:jar:999-SNAPSHOT:compile
    |  +- ...
    |  +- org.jboss.resteasy:resteasy-jackson2-provider:jar:4.7.7.Final:compile
    |  |  +- ...
    |  |  +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.14.1:compile
    |  |  |  +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.14.1:compile
    |  |  |  \- com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.14.1:compile
    ```
    
    This results in failed attempts to register the class for reflection
    when using the `quarkus-jackson` extension without
    `jackson-module-jaxb-annotations` in the classpath.
    
    Since we expect users to manually include the artifact in their
    dependencies even when not using `quarkus-resteasy-jackson` we maintain
    the registration in the `quarkus-jackson` extension but only perform it
    when the artifact is present in the classpath.
    zakkak committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    690eeaf View commit details
    Browse the repository at this point in the history