Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Opentelemetry docs #27112

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix Opentelemetry docs #27112

merged 1 commit into from
Aug 9, 2022

Conversation

llowinge
Copy link
Contributor

@llowinge llowinge commented Aug 3, 2022

Removed port 55680 as the default one is 4317 (based on https://github.com/open-telemetry/opentelemetry-collector/blob/main/receiver/otlpreceiver/README.md + open-telemetry/opentelemetry-python#1515).

Fixed insecure flag (explained in open-telemetry/opentelemetry-collector-contrib#5377).

Use fixed ports for jaegertracing container (easier to refer to those numbers).

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2022
@gsmet gsmet merged commit 65bb8b9 into quarkusio:main Aug 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 9, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2022
@clahres
Copy link

clahres commented Aug 10, 2022

I think there is a minor error in the docs:
The section receivers: [otlp,otlp/2] should be receivers: [otlp] in otel-collector-config.yaml. Should I open a new ticket?

@llowinge
Copy link
Contributor Author

@clahres Great catch, i've prepared PR to fix it in #27219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants