Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute - introduce the TemplateEnum annotation #22024

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Qute - introduce the TemplateEnum annotation #22024

merged 1 commit into from
Dec 9, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 8, 2021

@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Dec 8, 2021
@mkouba mkouba added this to the 2.7 - main milestone Dec 8, 2021
gastaldi
gastaldi approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 8, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c1ca90c

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✖ Native Tests - Messaging1 Set up JDK 11 ⚠️ Check → Logs Raw logs
✖ Native Tests - Misc3 Set up JDK 11 ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/opentelemetry/opentelemetry/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more

📦 extensions/opentelemetry/opentelemetry/deployment

✖ io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.spanNameWithoutQueryString line 88 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 9, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2021

Failing Jobs - Building 772f18b

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/opentelemetry/opentelemetry/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more

📦 extensions/opentelemetry/opentelemetry/deployment

✖ io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.spanNameWithoutQueryString line 88 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@mkouba
Copy link
Contributor Author

mkouba commented Dec 9, 2021

The "JVM Tests - JDK 11" failure does not seem to be related.

@mkouba mkouba merged commit 4224161 into quarkusio:main Dec 9, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 9, 2021
@jmini jmini mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@FroMage FroMage Awaiting requested review from FroMage

Assignees
No one assigned
Labels
area/documentation area/qute The template engine
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Qute: shorter enum constant access
2 participants
@mkouba @gastaldi