Override the Jandex version used by jandex-maven-plugin in build-parent #1921
Conversation
build-parent/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jboss</groupId> | ||
| <artifactId>jandex</artifactId> | ||
| <version>2.1.1.Final</version> |
There was a problem hiding this comment.
Minor but this is not properly indented: it should be 4 spaces. Could you fix it?
I think we need to fix having the version defined here but let's discuss that later and get this in.
There was a problem hiding this comment.
shouldn't it use ${jandex.version} ?
There was a problem hiding this comment.
Ah ah, I just asked about it in a previous review. We can't as it's defined in the bom and properties from the bom are not inherited.
I'm thinking about moving the version properties to the quarkus-parent artifact but that's an orthogonal discussion and we need this fixed sooner rather than later.
There was a problem hiding this comment.
ah right.
Why is the plugin not releasing in alignment of Jandex? We should ask @n1hility : Would be nicer to have the plugin version share the version of jandex itself, so to guarantee synch (and express compatibility)
There was a problem hiding this comment.
Yeah, it's a separate project for now but I could see how it would be nice to have it as one project.
We have a PR waiting here: wildfly/jandex-maven-plugin#13 (comment) .
mkouba
force-pushed
the
issue-1920-jandex-version
branch
from
3714dc8
to
aed0a9e
Compare
Unfortunately we cannot re-use the version from BOM.