Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap cache and groupId fixes #1821

Merged

Conversation

aloubyansky
Copy link
Member

As discussed on the dev list:

  • removed everything related to quarkus-deployment-dependency.graph
  • move classpath cache from ~/.quarkus to project.basedir/target
  • changed groupId of bootstrap from io.quarkus.bootstrap to io.quarkus

@gsmet gsmet added this to the 0.13.0 milestone Apr 2, 2019
@Sanne
Copy link
Member

Sanne commented Apr 2, 2019

let's be careful here, we're about to merge several out-of-tree extensions.

They all mention <groupId>io.quarkus.bootstrap</groupId>, so depending on order of merges things will need to be adjusted.

@aloubyansky
Copy link
Member Author

Just in case, I won't mind rebasing this one.

@Sanne
Copy link
Member

Sanne commented Apr 2, 2019

Just in case, I won't mind rebasing this one.

Thanks :) just merged the flyway extension then #1649

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gsmet
Copy link
Member

gsmet commented Apr 3, 2019

@Sanne did you have any other extensions in mind? I think we can merge now?

@Sanne
Copy link
Member

Sanne commented Apr 3, 2019

@gsmet +1 to merge, I'll let the other "out of tree" being written extension authors know.

@aloubyansky could you let the mailing list know?

thanks!

@aloubyansky aloubyansky merged commit 7bb7273 into quarkusio:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants