Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyway devmode: Confirm before cleaning the schema #18080

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Flyway devmode: Confirm before cleaning the schema #18080

merged 2 commits into from
Jun 22, 2021

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jun 22, 2021 •
edited
Loading

image

@gastaldi gastaldi requested review from geoand and gsmet June 22, 2021 14:25
geoand
geoand approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably improve the UI in a later stage, but this is a very good idea.

We likely want the same thing with Liquibase

@gastaldi
Copy link
Contributor Author

@geoand good catch, done for Liquibase too

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building cb67cd3

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 22, 2021
@geoand geoand merged commit 398e88f into quarkusio:main Jun 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 22, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 22, 2021
@gastaldi gastaldi deleted the prompt branch June 22, 2021 15:54
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
@gastaldi gastaldi mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/flyway area/liquibase
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@gastaldi @geoand @gsmet