-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition on reading input in RESTEasy Reactive #15553
Conversation
I don't really see how this fixes it? If you are on a blocking thread then the pause() should be too late, while on an event loop thread pausing and resuming in the same method should have no effect? |
I may be wrong, but what I was seeing is that pause ensured that we could add the listeners. Is there a more proper way to get around that problem in Vert.x? |
After discussing (see https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Resteasy.20Reactive/near/229432044), this fix should be OK for now, but we might need to come up with a more general solution in the future |
I will let @stuartwdouglas or @FroMage approve it and merge :). |
Yup. OP also mentioned that he was going to test it, so let's see how that goes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the discussion and agree this is fine for now.
So waiting for the test before we merge? |
Let's give OP another half day :) |
The idea here is to ensure that Vert.x has not completed reading the input because we can install the proper listeners.
Without this change, the is a chance the input ends before we all the listeners thus resulting in an
IllegalStateException
being thrown.Fixes: #15479