Automatically register @JsonIdentityInfo generator and resolver in Jackson #15506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geoand ^ |
geoand
reviewed
Mar 5, 2021
extensions/jackson/deployment/src/main/java/io/quarkus/jackson/deployment/JacksonProcessor.java
Outdated
Show resolved
Hide resolved
|
Look, good thanks! Let's improve the comment and it should be good to go |
|
Great! Please squash the commits and the PR is going to go |
|
I am waiting for checks; I'll squash once checks (on the previous commit) pass |
|
That doesn't do CI any favors, but as you wish - it's not a problem |
Christopher-Chianelli
force-pushed
the
register-json-identity-generator-and-resolver
branch
from
4483695 to
e52ed3c
Compare
|
@geoand done (just wanted to make sure the test worked; IDE was giving me trouble running the tests hence why I was waiting on CI) |
|
Running the tests of the project from the IDE is always problematic for me, so I just resort to running from Maven |
geoand
approved these changes
Mar 5, 2021
geoand
added
triage/waiting-for-ci
This was referenced Mar 12, 2021
Merged
This was referenced Mar 12, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackson supports entities that refer to one another (perhaps in a recursive loop) via
@JsonIdentityInfo(where it uses an attribute to determine if two objects in json refer to the same thing). Currently, the generator and resolver of@JsonIdentityInfoare not registered for reflective, causing an error at runtime in native mode when jackson try to deserialize an object with the annotation.This PR registers the generator and resolver of
@JsonIdentityInfowhich fixes the issue (and add an example of it to the jackson integration tests.