Explain semantics of quarkus.rest.path; add tests #15474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebullient
changed the title
quarkus.rest.path
ebullient
changed the title
quarkus.rest.path
ebullient
changed the title
kenfinnigan
reviewed
Mar 9, 2021
| * JAX-RS resource URIs provided by Path annotations when there are no | ||
| * {@code @ApplicationPath} annotation defined on {@code Application} classes. | ||
| * <p> | ||
| * This value is always resolved relative to {@code quarkus.http.root-path}. | ||
| */ | ||
| @ConfigItem(defaultValue = "/") |
There was a problem hiding this comment.
Is it confusing that we're saying it's a relative path and then the default is an absolute?
There was a problem hiding this comment.
This is a substitute for @ApplicationPath .. it is JAX-RS. It will ALWAYS be interpreted relative to http.root-path. Always
There was a problem hiding this comment.
I'm trying to make that unambiguous .. by reference more JAX-RS things in JAX-RS-y language.
There was a problem hiding this comment.
@stuartwdouglas .. we could remove the default or leave it empty or.. ?
stuartwdouglas
requested changes
Mar 9, 2021
...c/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveServerConfig.java
Outdated
Show resolved
Hide resolved
stuartwdouglas
approved these changes
Mar 9, 2021
kenfinnigan
approved these changes
Mar 9, 2021
This was referenced Mar 12, 2021
Merged
This was referenced Mar 12, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #15030, we now have a convention in our config that leading slashes in configured paths matter.
Update doc for
quarkus.rest.pathto make clearer association with@ApplicationPathAdd a few tests to make expected behavior more obvious (and ensure it keeps working that way)